Support @Meta annotation #4378
Support @Meta annotation #4378
Conversation
This repeatable annotation can be used to create customized meta tags
| import java.lang.annotation.Target; | ||
|
|
||
| /** | ||
| * Defines a custom tag and its content that will be added to the HTML of the |
There was a problem hiding this comment.
custom tag?
As I understand it's a meta tag but with the name and content specified here.
This javadoc is confusing for me.
Would be good to rephrase.
| } | ||
| if (illegalValue) { | ||
| throw new IllegalStateException( | ||
| "Meta tag contains illegal value on name or content attribute."); |
There was a problem hiding this comment.
Which meta tag?
If there are many of them then it's hard to understand which one this message is about.
There was a problem hiding this comment.
Updated the Exception message to clarify that the error is from the annotation
| /** | ||
| * Returns the map which contains name and content of the customized meta | ||
| * tag for the target route chain that was navigated to, specified with | ||
| * {@link Meta} on the {@link Route} class or the {@link ParentLayout} of |
There was a problem hiding this comment.
Does Route and ParentLayout participate somehow in this code?
via the context.getPageConfigurationAnnotations(Meta.class) call ?
There was a problem hiding this comment.
Is it possible to have Meta for a class without Route or ParentLayout?
In any case it would be good to have a test for such case: it should either throw or work or do whatever expected.
There was a problem hiding this comment.
As it stated in the enhancement ticket, this annotation should work under the same context with Viewport, so i just took the javadoc from there.
Added one more test for using annotation without route, which expect to throw the InvalidRouteConfigurationException
There was a problem hiding this comment.
improve the javadoc
This repeatable annotation can be used to create customized meta tags